ansible-powerscale icon indicating copy to clipboard operation
ansible-powerscale copied to clipboard

Sonar fixes

Open meenakshidembi691 opened this issue 1 year ago • 1 comments

Description

This PR has Sonar fixes

Checklist:

  • [x] I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • [x] I have performed Ansible Sanity test using --docker default
  • [x] I have verified that new and existing unit tests pass locally with my changes
  • [x] I have not allowed coverage numbers to degenerate
  • [x] I have maintained at least 90% code coverage
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • [ ] Unit Test

meenakshidembi691 avatar Sep 26 '24 05:09 meenakshidembi691

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.84%. Comparing base (c5b1405) to head (7b41f63). Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
tests/unit/plugins/module_utils/mock_info_api.py 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   81.90%   82.84%   +0.94%     
==========================================
  Files         124      133       +9     
  Lines       13463    14477    +1014     
  Branches     1989     2133     +144     
==========================================
+ Hits        11027    11994     +967     
- Misses       1830     1834       +4     
- Partials      606      649      +43     
Flag Coverage Δ
units 82.84% <94.11%> (+0.94%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 26 '24 05:09 codecov-commenter