ansible-powermax icon indicating copy to clipboard operation
ansible-powermax copied to clipboard

Add ex vols to protected sg

Open SerDroide opened this issue 1 year ago • 3 comments
trafficstars

Description

Capability to add a volume, that belongs to a storage group protected with srdf, also to another storage group

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/ansible-powermax/issues/51

Checklist:

  • [X] I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • [] I have performed Ansible Sanity test using --docker default
  • [ ] I have verified that new and existing unit tests pass locally with my changes
  • [ ] I have not allowed coverage numbers to degenerate
  • [ ] I have maintained at least 90% code coverage
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [X] Backward compatibility is not broken

How Has This Been Tested?

I'm working on a collection that leverage this one and I have molecule tests that do add and remove volumes from storage groups

  • [X] Add existing and protect volume to a second storage group

SerDroide avatar Oct 25 '24 11:10 SerDroide

Can one of the admins verify this patch?

ansible-collections-svc avatar Jan 21 '25 11:01 ansible-collections-svc

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 54.58%. Comparing base (b4fd7c6) to head (eccc0f7).

Files with missing lines Patch % Lines
plugins/modules/storagegroup.py 0.00% 12 Missing :warning:
plugins/modules/volume.py 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   54.69%   54.58%   -0.12%     
==========================================
  Files          31       31              
  Lines        3863     3869       +6     
  Branches      580      581       +1     
==========================================
- Hits         2113     2112       -1     
- Misses       1548     1555       +7     
  Partials      202      202              
Flag Coverage Δ
units 54.58% <0.00%> (-0.12%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 23 '25 03:01 codecov-commenter

are there any news about this PR?

SerDroide avatar Apr 04 '25 08:04 SerDroide

@SerDroide , I will take a look at this shortly and verify. I will make sure it is included in the next PowerMax Ansible Release.

doriac11 avatar May 21 '25 13:05 doriac11