PyTorchNLPBook
PyTorchNLPBook copied to clipboard
No early stopping implemented in Chapter 3 (yelp)
The early_stopping_best_val never gets updated so the loss is ALWAYS smaller and early stopping never happens this line of code is missing in the if-else statement in update_train_stage function:
train_state['early_stopping_best_val'] = loss_t