PyTorchNLPBook icon indicating copy to clipboard operation
PyTorchNLPBook copied to clipboard

No early stopping implemented in Chapter 3 (yelp)

Open lisanka93 opened this issue 4 years ago • 1 comments

The early_stopping_best_val never gets updated so the loss is ALWAYS smaller and early stopping never happens this line of code is missing in the if-else statement in update_train_stage function:

train_state['early_stopping_best_val'] = loss_t

lisanka93 avatar Nov 17 '21 14:11 lisanka93