Android-AdvancedWebView icon indicating copy to clipboard operation
Android-AdvancedWebView copied to clipboard

Fix onReceivedError deprecation

Open rignaneseleo opened this issue 8 years ago • 2 comments

Without this fix, the webview goes to error page on some devices without motives

rignaneseleo avatar Feb 20 '17 15:02 rignaneseleo

Thanks a lot!

This is indeed an important issue that needs to get fixed.

However, from the documentation:

Note that unlike the deprecated version of the callback, the new version will be called for any resource (iframe, image, etc), not just for the main page.

So the new callback is not really a drop-in replacement for the old callback. I'm not really sure, yet, whether we should just add the call from one method to the other, or if there's something we could do in order to make the callbacks behave the same way. That would be great, of course.

Anyway, we should definitely leave this issue open and merge it soon, either in its current form or slightly modified. In the meantime, anybody who needs that fix immediately can insert it using their own WebViewClient in setWebViewClient.

ocram avatar Feb 20 '17 15:02 ocram

@rignaneseleo this makes no sense to set a target api. Because the error handler is in webviewer also. Please update your webviewer this is not version bindend. Had same error before, you can subscribe on webviewer open beta.

GitWessel avatar Apr 05 '17 13:04 GitWessel