workflow-cli icon indicating copy to clipboard operation
workflow-cli copied to clipboard

check if config comes from pipe and stat size is > 0

Open pfeodrippe opened this issue 8 years ago • 11 comments

Fixes #305

pfeodrippe avatar May 25 '17 04:05 pfeodrippe

@Joshua-Anderson Ok, I'll test better this weekend o/. deis config:pull didn't give me any trouble, but I'll check on it too

pfeodrippe avatar May 26 '17 13:05 pfeodrippe

@Joshua-Anderson You can see at this gist the test cli, it tests multiple cases for the deis config:push inputs.

You can download the dev deis binary zipped (it will be updated if needed) I've built for testing.

Maybe we could put these tests as part of the build tests (of course, changing the scripts accordingly for automation).

deis config:pull doesn't use stdin, so no need to modify it =)

pfeodrippe avatar May 27 '17 05:05 pfeodrippe

And how could I give a default to docopt-go at the help doc and override it at code? Maybe it can say to us if the path came from the terminal or from the default value. You can see I'm using a hacked name for the path (.no-file)

pfeodrippe avatar May 27 '17 13:05 pfeodrippe

Codecov Report

Merging #306 into master will decrease coverage by 0.24%. The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
- Coverage   72.71%   72.47%   -0.25%     
==========================================
  Files          59       59              
  Lines        4109     4193      +84     
==========================================
+ Hits         2988     3039      +51     
- Misses        793      821      +28     
- Partials      328      333       +5
Impacted Files Coverage Δ
cmd/cmd.go 66.66% <ø> (ø) :arrow_up:
cmd/config.go 48.97% <0%> (+5.07%) :arrow_up:
parser/config.go 86.25% <100%> (+0.32%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7313b43...806f3ad. Read the comment docs.

codecov-io avatar May 30 '17 23:05 codecov-io

Ok, man, no worries :) I'll try to work on it at the weekend. Let's check at the config:pull too o/

pfeodrippe avatar May 31 '17 21:05 pfeodrippe

@pfeodrippe is work on this PR still in progress? The next release (v2.16) is currently scheduled for this week and would be great to get this fix in!

vdice avatar Jul 03 '17 22:07 vdice

@vdice I'll have more time only after 2017-07-17, sorry =, but I'll keep working at this PR, maybe it will enter at v2.17?

pfeodrippe avatar Jul 04 '17 11:07 pfeodrippe

@pfeodrippe No problems; sounds great! 👍

vdice avatar Jul 05 '17 15:07 vdice

@pfeodrippe do you think this is something you can finish up in time for the September v2.18 release, or should we close this?

mboersma avatar Aug 09 '17 16:08 mboersma

@mboersma ok, gonna work on it until the September version

pfeodrippe avatar Aug 09 '17 17:08 pfeodrippe

Would you like to make this PR towards the fork of Deis - Hephy? Here is the link: https://github.com/teamhephy/workflow-cli

Cryptophobia avatar Mar 21 '18 13:03 Cryptophobia