workflow-cli icon indicating copy to clipboard operation
workflow-cli copied to clipboard

config:push with .env doesn't handle export or double quotes

Open deis-admin opened this issue 8 years ago • 4 comments

From @glenwong on June 4, 2015 23:19

If you have environment variables in your .env file that are surrounded by double quotes or start with an export they aren't handled correctly when pushed to deis. For example:

export REDIS_URL="redis://localhost:6379"

ends up as

export REDIS_URL: "redis://localhost:6379"

Where "export REDIS_URL" is the key and the value is still surrounded by double quotes which can then cause things to fail when the config is referenced.

Copied from original issue: deis/deis#3796

deis-admin avatar Jan 19 '17 21:01 deis-admin

From @mboersma on June 10, 2015 21:24

Are env vars containing spaces in their names legal on Heroku? If not, we should tighten the .env file validation rules; if so, we should probably document config:push and config:pull behavior more specifically around this case.

deis-admin avatar Jan 19 '17 21:01 deis-admin

From @bacongobbler on June 18, 2016 7:14

same answer as I laid out in https://github.com/deis/deis/issues/4512; we should move to a shared library or follow the spec laid out in https://github.com/bkeepers/dotenv#usage.

deis-admin avatar Jan 19 '17 21:01 deis-admin

We're had the same bug a few times. Locally they work fine using Foreman, but in prod they fail.

jeroenvisser101 avatar Jan 26 '17 13:01 jeroenvisser101

This issue was moved to teamhephy/workflow-cli#13

Cryptophobia avatar Mar 21 '18 14:03 Cryptophobia