logger icon indicating copy to clipboard operation
logger copied to clipboard

Published 20 hours ago • verified publisher icon deis

Write unit tests for the code herein

Open arschles opened this issue 9 years ago • 7 comments

Important sections of this codebase are protected by sync.Mutexes or sync.RWMutexes, so special attention should be paid to writing concurrent tests (so that we can run go test -race)

arschles avatar Apr 13 '16 16:04 arschles

Punting to beta4

arschles avatar Apr 21 '16 15:04 arschles

I'm moving this to RC1. Also note that I haven't looked at the state of the code or amount of coverage in unit tests yet. I just noticed that there are not many...

arschles avatar May 09 '16 19:05 arschles

reclassifying as tests rather than a bug

bacongobbler avatar May 19 '16 18:05 bacongobbler

@jchauncey would you be willing to take a crack at this or shall we punt to post-2.0?

bacongobbler avatar May 19 '16 18:05 bacongobbler

i have tests in stdout-metrics that does a lot of what we want to test in logger i just need time to port them. but yeah we should just wait

jchauncey avatar May 19 '16 19:05 jchauncey

@jchauncey Were said unit tests ever written? It looks like the logger had 70% coverage, though with recent refactors has fallen to 40%

Joshua-Anderson avatar Sep 09 '16 20:09 Joshua-Anderson

This issue was moved to teamhephy/logger#7

Cryptophobia avatar Mar 13 '18 19:03 Cryptophobia