extension-gpgs icon indicating copy to clipboard operation
extension-gpgs copied to clipboard

Update AndroidManifest.xml

Open alexandrecurtelin opened this issue 4 years ago • 7 comments

Removed the preceding slash that was preventing GPSP to work properly.

alexandrecurtelin avatar Mar 19 '21 15:03 alexandrecurtelin

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 19 '21 15:03 CLAassistant

with without this symbol it should be path to the string eg @string/app_id this symbol makes it possible to put the value itself instead of the reference to the value in strings here

AGulev avatar Mar 19 '21 15:03 AGulev

Hmm, this value has changed a few times. Most recent change:

https://github.com/defold/extension-gpgs/blame/master/gpgs/manifests/android/AndroidManifest.xml#L6

@SkaterDad GPGS is working as it is now right?

@AGulev good suggestion btw!

britzl avatar Mar 19 '21 16:03 britzl

keeping this value in "@string/app_id" is the safest way I think, but isn't so convenient. As I know if we wanna reat it as vulue we should have \ (with space) or first symbol of the ID in unicode, like \u0039 for if the first symbol 9

AGulev avatar Mar 19 '21 17:03 AGulev

otherwise parser is looking for @sting/ here

AGulev avatar Mar 19 '21 17:03 AGulev

@britzl the current version works for me. I haven't tried building for a month or so, but the published game is fine.

SkaterDad avatar Mar 19 '21 18:03 SkaterDad

So there are conflicting suggestions here. The PR suggests dropping the space while one user confirms that it works as it is. I do not know what is correct.

One option may be to change how GPGPS is initialized and let the user do it himself or do it from C (and read the config value from game.project)

britzl avatar Mar 27 '21 07:03 britzl