haystack-core-integrations
haystack-core-integrations copied to clipboard
tests: deserialized AWS signer for IAM auth fails
Related Issues
- fixes #issue-number
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
- I have read the contributors guidelines and the code of conduct
- I have updated the related issue with new insights and changes
- I added unit tests and updated the docstrings
- I've used one of the conventional commit types for my PR title:
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.
I've copied here my Slack message. 👇
I found 2 different errors:
- as you pointed out,
SentenceWindowRetrievaldeserialization is wrong -> should usedoc_store_class.from_dictinstead ofdefault_from_dict - ~~
OpenSearchDocumentStorefrom_dictmethod tries to deserialize_http_auth, butto_dictstores this info inhttp_auth~~
The issue was fixed (tests are passing).
@ArzelaAscoIi @FHardow feel free to close this PR if everything is OK.