haystack-core-integrations icon indicating copy to clipboard operation
haystack-core-integrations copied to clipboard

tests: deserialized AWS signer for IAM auth fails

Open ArzelaAscoIi opened this issue 1 year ago • 1 comments

Related Issues

  • fixes #issue-number

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

ArzelaAscoIi avatar Aug 12 '24 11:08 ArzelaAscoIi

I've copied here my Slack message. 👇

I found 2 different errors:

  • as you pointed out, SentenceWindowRetrieval deserialization is wrong -> should use doc_store_class.from_dict instead of default_from_dict
  • ~~OpenSearchDocumentStore from_dict method tries to deserialize _http_auth, but to_dict stores this info in http_auth~~

anakin87 avatar Aug 12 '24 13:08 anakin87

The issue was fixed (tests are passing).

@ArzelaAscoIi @FHardow feel free to close this PR if everything is OK.

anakin87 avatar Aug 19 '24 15:08 anakin87