haystack-core-integrations icon indicating copy to clipboard operation
haystack-core-integrations copied to clipboard

feat: Add Azure AI Search integration

Open Amnah199 opened this issue 1 year ago • 3 comments

Related Issues

  • fixes #950

Proposed Changes:

Implement a document store for Azure AI Search.

How did you test it?

Add unit tests for document store

Notes for the reviewer

Ready for an early feedback to detect any major changes needed in design. Current status: Adding filters and search operations. The filter_documents() method is incomplete.

Checklist

Amnah199 avatar Jul 31 '24 23:07 Amnah199

@vblagoje ready for your to give a high level feedback on the progress so far.

Amnah199 avatar Aug 07 '24 11:08 Amnah199

@Amnah199 looks like a step in the right direction. We also need to:

  • update values in integrations/azure_ai_search/pydoc/config.yml file
  • exercise this integration in examples dir (see other integrations)
  • Continue building examples for retriever and other required components

Examples dir and example scripts added are not only helpful to users but to you and reviewers to get a feel if everything is alright with this component from DX/UX perspective. With examples it is then easy to continue with writing a Notion docs page @dfokina use to create a new Haystack docs page we'll need for eventual merge.

vblagoje avatar Aug 07 '24 12:08 vblagoje

@vblagoje thanks for the review. I will work on the examples after completing the implementation of filters and retrievers.

Amnah199 avatar Aug 07 '24 13:08 Amnah199

Closing this PR due to unresolved conflicts. A new PR has been opened here.

Amnah199 avatar Oct 02 '24 19:10 Amnah199