haystack-core-integrations icon indicating copy to clipboard operation
haystack-core-integrations copied to clipboard

add openvino generator

Open openvino-dev-samples opened this issue 1 year ago • 4 comments

openvino-dev-samples avatar Jul 15 '24 08:07 openvino-dev-samples

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 15 '24 08:07 CLAassistant

Hey @OpenVINO-dev-contest this work is solid! Thank you for your contribution. I have consulted with my colleagues internally and we suggest to make this a https://github.com/deepset-ai/haystack-integrations contribution. This means that essentially everything stays the same as in this PR but you maintain it yourself in your repo of choosing. And we'll list it in our https://haystack.deepset.ai/integrations as well.

vblagoje avatar Jul 23 '24 14:07 vblagoje

hi @vblagoje you mean this PR will not be merged, right ?

I have open a discussion before this PR, and it said haystack-core-integrations) is open for contribution.

https://github.com/deepset-ai/haystack/discussions/7998

openvino-dev-samples avatar Jul 23 '24 15:07 openvino-dev-samples

hi @vblagoje you mean this PR will not be merged, right ?

I have open a discussion before this PR, and it said haystack-core-integrations) is open for contribution.

deepset-ai/haystack#7998

@OpenVINO-dev-contest my colleague most likely didn't know about this decision. Every integration in this repository requires full attention from us in terms of documentation, release cycles, adding new features, maintenance and bug fixes. We are stretched too thin. Noting related to importance of this integration and code quality but mere resources. We have made decision to be really restrictive about new integrations in this repo because we simply can't support it at the high level we have set for ourselves. Hope you understand and issue PR at https://github.com/deepset-ai/haystack-integrations - we'll gladly merge it there and list it on https://haystack.deepset.ai/integrations Everything is pretty much the same in terms of user experience but in this case you maintain the integration yourself.

vblagoje avatar Jul 23 '24 18:07 vblagoje

Closing, hopefully we'll get an independently maintained OpenVINO integration for Haystack.

vblagoje avatar Oct 04 '24 09:10 vblagoje