haystack-core-integrations
haystack-core-integrations copied to clipboard
Improve `OpenSearchDocumentStore.__init__` arguments
Closes #671
As explained in the issue, I am proposing to change a bit the arguments that OpenSearchDocumentStore accepts.
The goal is:
- First, to allow the user to set the most appropriate
max_chunk_bytes. (The current default makes this component fail for certain deployments) - To be more transparent on which arguments are required and which
**kwargsare passed to theOpenSearchclient. Currently the docstring does not specify which**kwargsare passed to the client, and which are passed toself._client.indices.create.
Happy to hear your thoughts on how I can improve this PR :)
Thanks for this contribution @EdAbati we'll be getting back to you shortly. @tstadel how does this proposal sound to you?
@vblagoje contribution looks like a nice improvement. @EdAbati thanks for raising this. I left two comments that should be tackled before merging.
@EdAbati have you had a chance to look at the potential issues pointed by Thomas?
Hi both thank you for the review. :) I am a bit busy this week, I'll go back to this PR next week
Hi, I made some changes to fix what was suggested :) I can see a mypy error but only in the python 3.9 CI. do you know what is causing it and/or how I could solve it?
Tests are green 👍
🙏 @masci and thanks a lot for this contribution @EdAbati , looks ok to you now @tstadel ?