haystack-core-integrations icon indicating copy to clipboard operation
haystack-core-integrations copied to clipboard

[Integration] Request to support FAISSDocumentStore in 2.x

Open v3ss0n opened this issue 1 year ago • 7 comments

Is your feature request related to a problem? Please describe. We are having problem migrating current version to 2.0 due to no FAISSSupport Describe the solution you'd like Due to is simplicity , performance and developer experience , we and many other RAG solution provider are now using FAISS . So it would be nice to integrate it.

Describe alternatives you've considered QDrant and many others are not approved by some organization yet because they are very new and not backed by big vendors.

v3ss0n avatar May 06 '24 11:05 v3ss0n

Hi @v3ss0n and thanks for the feature request.

Do you envision an exact porting of the FAISS document store from Haystack 1.x, with the accompanying persistent storage, or would an in-memory, pure-FAISS solution also work?

masci avatar May 10 '24 05:05 masci

Exact porting is not necessary as long as we can use Fiass as DS , and yes of-course we are looking forward for both persistant and and in-memory DS but whatever work first.

v3ss0n avatar May 10 '24 10:05 v3ss0n

I think having in-memory, basic support for FAISS can be done rather easily. The problem with persistence is that FAISS alone can't manage metadata, so we need to pair it with another storage. We used sqlite in the previous version of Haystack and that turned out to be a mess, so this time it'd be better to pick a storage that's closer to the nature of FAISS - but this will require to prioritize this issue, and not sure this can happen soon.

masci avatar May 10 '24 11:05 masci

yeah i agree , sqlite store was a mess and hard to manage. Lets start with in-memory.

v3ss0n avatar May 10 '24 11:05 v3ss0n

Hi FAISS is more important then you might give it credit for, it is necessary for Haystack to move FAISS support to version 2. One of the most important attributes I like about FAISS That it uses local files and for document store, it can use SQL lite, This is a great advantage when we have small but many different isolated databases it may not be very scalable but there is a case to be made for small number of users requiring specialized RAG type applications.

mlokhandwala avatar Sep 10 '24 12:09 mlokhandwala

Would be very useful to have FAISS support in Haystack 2.0!

smach avatar Sep 10 '24 16:09 smach