haystack-core-integrations icon indicating copy to clipboard operation
haystack-core-integrations copied to clipboard

Published 20 hours ago • verified publisher icon deepset-ai

Refactor Weave integration

Open anakin87 opened this issue 5 months ago • 1 comments

As reported in #2038, when working on fixing types, I discovered that currently the Weave Tracer violates of the Liskov Substitution Principle and fixing this does not seem straightforward.

https://github.com/deepset-ai/haystack-core-integrations/blob/14fd1b8b276a62a5630e474e047ecaf1816e904b/integrations/weights_and_biases_weave/src/haystack_integrations/tracing/weave/tracer.py#L157-L159

Since I'm not an expert on this integration, I can't confidently say if this is problematic or no. (Langfuse might have similar problems but I am not sure).

We should evaluate whether this causes practical problems and if it's worth refactoring the integration to address it.

anakin87 avatar Jul 01 '25 14:07 anakin87