haystack-core-integrations
haystack-core-integrations copied to clipboard
deepset-ai
feat: Add NvidiaChatGenerator
Related Issues
- fixes https://github.com/deepset-ai/haystack-core-integrations/issues/1483
Proposed Changes:
- Add NvidiaChatGenerator
How did you test it?
- new unit tests
- ran one new integration test locally
Notes for the reviewer
No streaming or run_async added. Could be done in a separate PR. I kept the implementation of NvidiaChatGenerator and NvidiaGenerator as similar as possible
As an alternative, I experimented with just inheriting from OpenAIChatGenerator. It's in the draft as AlternativeNvidiaChatGenerator.
Checklist
- I have read the contributors guidelines and the code of conduct
- I have updated the related issue with new insights and changes
- I added unit tests and updated the docstrings
- I've used one of the conventional commit types for my PR title:
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.
