dlwpt-code icon indicating copy to clipboard operation
dlwpt-code copied to clipboard

Missing files/functions in p2ch13 directory.

Open STRZGR opened this issue 4 years ago • 3 comments

There are several missing files in the "p2ch13" directory.

  • "p2ch13.training" is missing LunaTrainingApp, and without this function several other files/functions will break.

  • "p2ch13_explore_data.ipynb" tries to import old_build2dLungMask from "p2ch13.dsets", but this is also missing.

  • build2dLungMask needs LunaDataset, but this is missing from 'p2ch13.dsets'.

  • "p2ch13_explore_data.ipynb" tries to import SegmentationMask and MaskTuple from the file "p2ch13.model_seg", but "p2ch13.model_seg" is not in this directory.

Previous chapters have identically named files for some of these, but these do not seem to be interchangeable. I tried importing earlier versions of the missing files listed above into the "p2ch13" directory, but this caused numerous functions to break.

In addition, I noticed these issues in the notebooks for p2ch13:

  • Last cell of "p2ch13_explore_data.ipynb" - TrainingLuna2dSegmentationDataset() has the argument "batch_size", which is no longer a valid parameter.

  • TrainingLuna2dSegmentationDataset returns only 4 objects, but the output is assigned to 5 variables. This is a problem in both "p2ch13_explore_data.ipynb" and "p2ch13_explore_data_v2.ipynb"

  • In "p2ch13_explore_data_v2.ipynb", CandidateInfoTuple needs to be imported from from p2ch13.dsets

  • The notebook "p2ch13_explore_diagnose.ipynb" tries to import the file "diagnose", but this is missing from the "p2ch13" directory. Should this notebook just be deleted from the repository?

STRZGR avatar Feb 05 '21 07:02 STRZGR

Bump!

bogdan-ivan avatar May 14 '21 14:05 bogdan-ivan

Any update on this? I couldn't find the files as well

RahimiPhz avatar Jun 02 '21 07:06 RahimiPhz

None of the notebooks work. In many cases you can figure out how to fix them.

sfleisch avatar Dec 30 '21 04:12 sfleisch