deckdeckgo icon indicating copy to clipboard operation
deckdeckgo copied to clipboard

lazy-img attributes img-height img-width don't work

Open flatmax opened this issue 3 years ago • 3 comments

Affected part of DeckDeckGo

  • [ ] Web Components

Reproduction

Can' use img-width and img-height

Steps to reproduce:

  1.     <deckgo-lazy-img img-src=url img-width=50 img-height=60>        </deckgo-lazy-img>
    

Expected Behavior

The image to resize

Actual Behavior

The image doesn't resize

Environment

  • Browser(s): chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): linux

flatmax avatar Aug 18 '22 06:08 flatmax

Did you inspect the shadowed dom, are the width and height applied?

As you can see in the component here https://github.com/deckgo/deckdeckgo/blob/00d532ffc7b03795a674984d2fe8d08d57cc3e2e/webcomponents/lazy-img/src/components/lazy-img/deckdeckgo-lazy-img.tsx#L299 width and height should be set if the props are set.

peterpeterparker avatar Aug 18 '22 06:08 peterpeterparker

Oh ok - are you saing that the attributes img-width and img-height aren't working ? I should use the properties instead ?

flatmax avatar Aug 18 '22 22:08 flatmax

Actually I'm saying these should work but asking if you had a look to the shadowed content to see if anything seems not to work as expected?

peterpeterparker avatar Aug 19 '22 20:08 peterpeterparker