react-native-sortable-listview icon indicating copy to clipboard operation
react-native-sortable-listview copied to clipboard

Published 20 hours ago • verified publisher icon deanmcpherson

mounting issue

Open markentingh opened this issue 7 years ago • 1 comments

When dragging a component, I noticed that the component being dragged executes the componentWillMount method upon drag start. I believe that this would be a bug. The component shouldn't have to remount just to be dragged.

In my case, I have a component that does some heavy processing upon being mounted, therefore, when I try to sort components, there is some huge lag between pressing and dragging the selected component.

markentingh avatar Sep 29 '18 05:09 markentingh

componentWillMount is now eligible for removal:

Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

  • Move code with side effects to componentDidMount, and set initial state in the constructor.

  • Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: SortableListView

madandrija avatar Oct 02 '19 11:10 madandrija