prometheus-ecto

prometheus-ecto copied to clipboard

Implementing label_value does not work

1

I have the instrumenter working fine w/ default settings and I see my Ecto metrics come through prometheus: ``` # TYPE ecto_db_query_duration_microseconds histogram # HELP ecto_db_query_duration_microseconds The time spent executing...

ambuznego

Record Idle Time, Add Repo Label & Make config accessible in label_value()

4

Adds support for the new idle_time metric introduced in ecto_sql 3.3.0, adds repo labeling, and allows config to be accessed in `label_value()`. Repo label and the config change would be...

ackerdev

Do not convert time because of https://github.com/deadtrickster/prometheus.erl/issues/106. Prometheus.erl will convert from `native` time to the time unit derived by the metric name automatically, causing double conversion.

tomaspinho

Instrument new idle_time metric introduced on ecto_sql 3.3.0

1

[ecto_sql v3.3.0](https://github.com/elixir-ecto/ecto_sql/blob/master/CHANGELOG.md#v330-2019-12-11) introduced a new metric `idle_time` that measure [the time the connection spent waiting before being checked out for the query](https://hexdocs.pm/ecto/Ecto.Repo.html#module-adapter-specific-events)

GPrimola

Hey there! Im trying to use the last ecto version but having an issue with this lib dependency. ``` Dependencies have diverged: * ecto (Hex package) the dependency ecto 3.4.0...

mustela

jfornoff

Fail to execute Ecto.adapters.SQL.query!/4 when config :myapp, MyApp.Repo, :logger is set to [MyApp.Metrics.EctoInstrumenter, Ecto.LogEntry] in release mode.

3

Recently we experience a strange issue after adding prometheus ecto to our phoenix app. Our migration script succeed in dev mode when developing locally, but once apply from a release...

tatiesmars

Argument error during migration with Ecto.Repo.delete_all/1

2

Using `prometheus_ecto` version 1.3.0, I observe the following stack trace: ``` ** (ArgumentError) argument error (stdlib) :ets.lookup(:prometheus_histogram_table, {:default, :ecto_db_query_duration_microseconds, [:ok], 3}) src/metrics/prometheus_histogram.erl:196: :prometheus_histogram.observe/4 lib/core/repo_instrumenter.ex:5: Core.RepoInstrumenter.log/1 lib/core/repo.ex:2: Core.Repo.__log__/1 (db_connection) lib/db_connection.ex:1186: DBConnection.log/6...

alex-knowles

Dialyzer warnings

4

Hi! I'm getting the following dialyzer warning on `Prometheus.EctoInstrumenter`: `The call 'Elixir.System':convert_time_unit(_@1::any(),'native','micro_seconds') breaks the contract (integer(),time_unit() | 'native',time_unit() | 'native') -> integer()` Seems like it's unhappy with the first argument...

rudigiesler