Ron Evans

Results 985 comments of Ron Evans
trafficstars

I think this is an excellent idea. Yes, please.

Just a few general comments. As @aykevl mentioned the custom domain package naming would be `tinygo.org/x/device/sam`. We use that to more easily handle the requirements for custom domains/caching/etc. > So...

@dgryski any chance to look at this? :smile_cat:

Played around with it, but was not able to get anything to happen, nor to notice any specific problems. Very odd.

CCing @ekettenburg just in case he might take an interest in what we are trying to do here.

@aykevl what do you think? This would be a great feature to get in to this release.

@aykevl what do you think about this PR? It would be great to merge it! :smile_cat:

Looks like need to run `go fmt`: ``` Unformatted: src/runtime/timer_go118.go make: *** [Makefile:180: fmt-check] Error 1 ```

I am very excited about this feature. Thank you @kenbell for actually getting it in, and thanks @aykevl for all the original work on it. Now merging!

Hmm, seems like macOS has troubles passing CI https://github.com/tinygo-org/tinygo/runs/7972019922?check_suite_focus=true#step:12:19780 Trying to run it a third time now...