Ron Evans

Results 985 comments of Ron Evans
trafficstars

@StarkovOleksandr that would be fantastic! Yes, please.

@StarkovOleksandr please see https://github.com/tinygo-org/drivers/blob/release/CONTRIBUTING.md#some-specific-hardware-you-want-to-use-does-not-appear-to-be-in-the-tinygo-drivers

https://github.com/tinygo-org/drivers/blob/release/CONTRIBUTING.md#how-to-run-tests however perhaps we should be explicit about doing that in the previous section?

> Another would be to refactor the machine package itself to expect a pointer so that we can define Configure(interface{}) in the drivers.SPI interface. To clarify, this would mean changing...

The only other places where there is use of SPI that goes beyond the interface are https://github.com/tinygo-org/drivers/blob/release/ili9341/spi_atsamd21.go https://github.com/tinygo-org/drivers/blob/release/ili9341/spi_atsamd51.go I'm not sure why that functionality is in the driver? Anyhow, the...

I agree that we need to require all setup take place outside the driver. We will have to make a number of changes to remove those calls. So this change...

I was going to propose something like `spi.Configure(*SPIConfig)` but what you suggest is better as it makes things even more explicit.

That would be a good use for https://pkg.go.dev/periph.io/x/periph/conn/physic probably.

This is the file in question here: https://github.com/google/periph/blob/v3.6.8/conn/physic/units.go If only it were in its own package with no other dependencies on periph's `Conn`. cc/ @maruel