fake_pipe icon indicating copy to clipboard operation
fake_pipe copied to clipboard

Published 20 hours ago • verified publisher icon ddrscott

New Mutation Methods

Open f3lan opened this issue 6 years ago • 5 comments

Hi @ddrscott,

I saw that the PR https://github.com/ddrscott/fake_pipe/pull/2 was incomplete. So I took the chance to finish the work of @biozid-0208.

What I did:

  1. I merged the newest master and the feature branch into a new branch.
  2. I cleaned up the spec/anonymizer/mutator_spec.rb file, to be in consistence with the the list of all methods.
  3. I fixed the specs.
  4. I updated the README.me and added the new methods to the list.

I hope, you can use this MR, otherwise let me know how I can help you.

Best Regards,

@f3lan

f3lan avatar Nov 15 '19 09:11 f3lan

Sorry for the late response, I'll get on this tomorrow to rebase, double check, and merger.

ddrscott avatar Nov 21 '19 23:11 ddrscott

Hi @ddrscott,

no worries. If you need help or if I can clarify something, let me know.

Best regards,

@f3lan

f3lan avatar Nov 22 '19 11:11 f3lan

Hi @ddrscott,

I fixed the merge request for this MR. 😄.

Best regards,

@f3lan

f3lan avatar Nov 28 '19 08:11 f3lan

Can you reset to ddrscott:master and git cherry-pick cf267f6d8db1cd216cf15b40e355e4bf7d737b2d? That'll make it so I can merge using GH.

BTW. Thanks for all of this! I'm glad someone still getting use out of the project.

ddrscott avatar Nov 28 '19 11:11 ddrscott

Hi @ddrscott,

Unfortunately I do not understand you here. It is for me a bit problematic to cherry-pick a merge commit. If you want I can rebase and deselect commits you may not want in the master.

We are happy to use this gem for anonymise our test databases. Thanks for the great work!

Best regards,

@f3lan

f3lan avatar Nov 28 '19 13:11 f3lan