dicomweb-client icon indicating copy to clipboard operation
dicomweb-client copied to clipboard

Published 20 hours ago • verified publisher icon dcmjs-org

Typescript definitions

Open kerolloz opened this issue 4 years ago • 6 comments

kerolloz avatar Jun 21 '21 11:06 kerolloz

Are there available Typescript definitions?

juaesto avatar Sep 29 '22 05:09 juaesto

Not that I know of. If someone feels strongly they could make a PR.

pieper avatar Sep 29 '22 11:09 pieper

We have type definitions in Slim and it would be nicer to include them in the package distribution.

hackermd avatar Sep 29 '22 11:09 hackermd

Thank you @hackermd. Yes, it would make more sense for those to be here along with some tests to ensure they stay up to date if/when the API evolves.

pieper avatar Sep 29 '22 12:09 pieper

@pieper could you help porting them over from the application into the library?

For the tests, we may need to introduce typescript as a dev dependency.

hackermd avatar Sep 29 '22 12:09 hackermd

I don't have any particular need for typescript but perhaps @juaesto or @kerolloz would be willing to help out.

pieper avatar Sep 29 '22 12:09 pieper