Daco Harkes

Results 411 comments of Daco Harkes
trafficstars

Using the workaround adds a 250 ms slowdown to flutter app builds: * https://github.com/flutter/flutter/issues/134427#issuecomment-1715904480

```dart class SomeClass { static final Version latestVersion = Version(1, 2, 0); } ``` Feels more natural to write const for something like this. If it would have been an...

Yes, we'd have to make `_text` nullable, and recompute on every `toString()` invocation if it's null.

> What about helper files, if my `build.dart` is getting too complex? Should they not be stored in `hooks/src/` or similar? I'd probably put these in `src/`. I think for...

> I think we are converging on a server-side check. That is easier to update/relax over time. Ah right, because we can just deploy a new version. With a client-side...

Yes, this leaves a dangling pointer. * `toNativeUtf8` allocates memory in C land. * the `Pointer` in Dart points to that memory * that pointer is passed as an argument...

cc @domesticmouse

I also ran into this, and also made a workaround. Without knowing about this discussion, I also gravitated towards using the package root. That being said, a `test/data/` approach would...

> That being said, a `test/data/` approach would have probably also worked. My test data contains dart projects that contain tests, so nesting it inside `test/` doesn't work for my...

> We do have the `filename` configuration option https://github.com/dart-lang/test/blob/master/pkgs/test/doc/configuration.md#filename. You should be able to use that in the top level package to include only the dirs you want, and then...