David Carr

Results 82 comments of David Carr

thanks, I'll have a look at this tonight.

we're not looking to argue, its a massive PR, going to find some time to look over this and try out with a few apps I have. The tests are...

@solomon-ochepa as soon as I pull in this PR I'm getting this error ``` BadMethodCallException Method Nwidart\Modules\Laravel\Module::app_path does not exist. at vendor/laravel/framework/src/Illuminate/Macroable/Traits/Macroable.php:115 111▕ */ 112▕ public function __call($method, $parameters) 113▕...

thanks that error is fixed now, my tests are failing because Livewire can't see my components. If you need a project that uses Livewire you can use https://github.com/laravel-modules-com/fuse

I understand this is not about Livewire but my components work perfectly until I use this branch. tested on 3 different apps. ``` Livewire\Exceptions\ComponentNotFoundException Unable to find component: [admin::admin.notifications-menu] ```

if this is still an issue please let us see what your root `composer.json` contains.

identified the problem, applied a fix, will be doing a release shortly.

I think that's a good solution, another way would be when your module used its own vite config something like this may work ```js import { defineConfig } from 'vite';...

Looking into this, on a fresh Laravel install with no modules installed. load time is 40 miliseconds. I've installed 150 modules than load time goes to around 3 seconds. I...

@alissn I've pulled down 11.1.0 I have 140 modules Boot time is high, still need to look at this I think. ![CleanShot 2024-09-14 at 14 57 37](https://github.com/user-attachments/assets/168ed326-3ef6-44d4-8666-dc6a1a14ad7c)