dbt-core icon indicating copy to clipboard operation
dbt-core copied to clipboard

Migrate to `Protobuf>=5.26.0,<6`

Open QMalcolm opened this issue 1 year ago • 5 comments

Housekeeping

  • [X] I am a maintainer of dbt-core

Short description

We're currently depend on protobuf 4.y.z, and protobuf 5 is coming out soon. Thus far they've released three release candidates (5.26.0-rc1, 5.26.0-rc2, 5.26.0rc-3). We don't know exactly when the 5.26.0 production release will happen. However, if history is any indicator, it'll probably be out by the end of March 2024 (less than a month). It's hard to say how long it will take for the python community at large to migrate, but we should be prepared to do so.

Acceptance criteria

  • dbt-core depends on protobuf v5
  • dbt-core doesn't depend on protobuf v4

Suggested Tests

The current tests should still pass

Impact to Other Teams

None

Will backports be required?

No

Context

No response

QMalcolm avatar Mar 02 '24 01:03 QMalcolm

It's out now.

It lead to this issue: https://github.com/dbt-labs/dbt-core/issues/9759

dbeatty10 avatar Mar 14 '24 00:03 dbeatty10

Any updates on migrating to protobuf v5?

Nikohm avatar Aug 02 '24 01:08 Nikohm

Bump

ogescalante avatar Aug 02 '24 16:08 ogescalante

@Nikohm and @ogescalante We don't have a timeline for protobuf v5.

dbeatty10 avatar Aug 03 '24 23:08 dbeatty10

I've opened a PR in dbt-common that addresses this: https://github.com/dbt-labs/dbt-common/pull/211

ewhauser avatar Oct 19 '24 22:10 ewhauser

Bump

acauquil avatar Nov 05 '24 19:11 acauquil

Bump

netanelm-upstream avatar Nov 12 '24 13:11 netanelm-upstream

I've opened a PR in dbt-common that addresses this: dbt-labs/dbt-common#211

Thank you!

Nikohm avatar Jan 08 '25 21:01 Nikohm

can this be closed now? https://github.com/dbt-labs/dbt-common/pull/219

Nikohm avatar Feb 11 '25 19:02 Nikohm