dbt-bigquery icon indicating copy to clipboard operation
dbt-bigquery copied to clipboard

fix: alter table description without full_refresh

Open kiwamizamurai opened this issue 1 year ago • 9 comments

resolves dbt-labs/dbt-adapters#585 docs dbt-labs/docs.getdbt.com/#

Problem

when materialization is incremental, table description does not be updated.

Solution

I implemented the method that alters the table description without table recreation.

Checklist

  • [x] I have read the contributing guide and understand what's expected of me
  • [x] I have run this code in development and it appears to resolve the stated issue
  • [x] This PR includes tests, or tests are not required/relevant for this PR
  • [x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

kiwamizamurai avatar Mar 14 '24 10:03 kiwamizamurai

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @kiwamizamurai

cla-bot[bot] avatar Mar 14 '24 10:03 cla-bot[bot]

@cla-bot cla has been signed

kiwamizamurai avatar Mar 15 '24 12:03 kiwamizamurai

@colin-rogers-dbt hello. this is my frist pr. please help me. is there anything else i should do?

kiwamizamurai avatar Mar 15 '24 12:03 kiwamizamurai

@emmyoop could you help me?

kiwamizamurai avatar Mar 19 '24 21:03 kiwamizamurai

Changelog file might be required?

kiwamizamurai avatar Mar 25 '24 11:03 kiwamizamurai

see https://github.com/dbt-labs/dbt-bigquery/issues/1138#issuecomment-2018762523

dataders avatar Mar 25 '24 19:03 dataders

@dataders

Could you review my PR? I have verified in my local environment with the same step.

  • https://github.com/dbt-labs/dbt-bigquery/issues/1138#issue-2185777477

kiwamizamurai avatar Mar 28 '24 10:03 kiwamizamurai

Hi @kiwamizamurai any updates on this PR?

martinazapletalova avatar Sep 26 '24 09:09 martinazapletalova

@colin-rogers-dbt @dataders could you review this pr?

kiwamizamurai avatar Oct 11 '24 04:10 kiwamizamurai