dbr/Ben

Results 190 comments of dbr/Ben

> The tests expect that, in case of failure to move a file (e. g. file already exists at destination without overwrite flag), the original file should have been renamed...

I think this would be much tidier done as part of a wrapper script, e.g 1. Run tvnamer on the folder 2. Have tvnamer move the good files into a...

Patterns that match against the full path is planned, http://dbr.lighthouseapp.com/projects/36049/tickets/9-episode-patterns-that-match-against-path Handling of "Blah, The" type series names is something thetvdb's API should probably handle, rather than client code, although it...

Hm, I'll bear this in mind - with the rewrite of the code I'm experimenting with, it might be possible to do this nicely as an "alternative UI" (which writes,...

Cool, thanks! A few small things: 1. A comment on `filenames = [filename, fullname]` etc would be good, as it was momentarily confusing why the code was like that (also,...

This is worth mentioning - it would be quite reasonable to assume the filename comparison might be `if ext.lower() in Config['valid_extensions']:` (which probably isn't a bad idea..) Pretty sure filesystem...

Yeh that seems like a good approach, and shouldn't be to hard to implement once the renaming logic is tidied up in the v4.0

Hm, strange.. In `tvnamer/main.py` you could change: ``` python try: cnamer.rename( new_fullpath = newFullPath, always_move = Config['always_move'], always_copy = Config['always_copy'], leave_symlink = Config['leave_symlink'], force = Config['overwrite_destination']) except OSError, e: log().warn(e)...

Huh, where is that code? In shutil somewhere? Can you attach a complete traceback? The error is very likely due to a difference between the two file systems - I've...

I'd say just ignoring errors form the copystat would be fine, something like: ``` python def copy_file(old, new): p("copy %s to %s" % (old, new)) shutil.copyfile(old, new) try: shutil.copystat(old, new)...