selecto icon indicating copy to clipboard operation
selecto copied to clipboard

Feature Request: SelectByClick on mouseUp events

Open MW360 opened this issue 3 years ago • 3 comments

Environments

  • Framework name: Selecto
  • Framework version: 1.13.0 and later
  • Component name: React-Selecto
  • Component version: 1.13.0 and later
  • Testable Address(optional): e.g.: https://daybrush.com/selecto/storybook/?path=/story/selecto--continue-to-select-through-the-toggle-key

Description

Hi, thank you for providing such a great Library.

I am trying to integrate Selecto together with React Moveable into BigBlueButton as part of my Bachelor Thesis: bigbluebutton/bigbluebutton#13929, bigbluebutton/bigbluebutton#2351

It seems like SelectByClick only works on mouseDown events and not on mouseUp events. It would be great if there will be an option to configure that the Selection gets only added on mouseUp events.

MW360 avatar Jan 20 '22 20:01 MW360

@MW360

So I will change the behavior. Thank you.

daybrush avatar Mar 09 '22 11:03 daybrush

@MW360

  • selecto 1.14.0
  • react-selecto 1.14.0
  • preact-selecto 1.14.0
  • ngx-selecto 1.14.0
  • svelte-selecto 1.14.0
  • vue-selecto 1.14.0
  • vue3-selecto 1.0.0
  • lit-selecto 1.14.0

selecto's new version is released. Check it again.

clickBySelectEnd option is added.

https://github.com/daybrush/selecto#option-behaviors

Set options:

  • selectFromInside: false
  • selectByClick: true
  • clickBySelectEnd: true

daybrush avatar Mar 09 '22 17:03 daybrush

Hi, thank you for implementing the feature!

Unfortunatly, it seems that my description of the feature was not detailed enough.

So I think the problem was this sentence of my description:

option to configure that the Selection gets only added on mouseUp events

I meant selection on mouseUp additionally to selection on drag. Further, the continueSelect and toogleContinue select should also work with selection on mouseUp. Also my idea was that selectFromInside should still be possible. So on drag, only the selection rectangle should be used for selection. On click on a single target without a further dragging, the element should be selected on mouseUp.

Sorry for my misleading description,

Best regards, Maximilian

MW360 avatar Mar 19 '22 16:03 MW360