moveable icon indicating copy to clipboard operation
moveable copied to clipboard

`drag` undefined on Rotate Group events

Open mamsoudi opened this issue 3 years ago • 3 comments

Environments

  • Framework name: Moveable (Vanilla)
  • Framework version: 0.33.0 and 0.31.0
  • Moveable Component version: -
  • Testable Address(optional): https://codesandbox.io/s/drag-undefined-rotategroup-fyk5pz?file=/src/index.ts

Description

What happens essentially after v0.33.0 is that onRotateGroup the drag object get's undefined. The link above is directly taken from the Storybook and opened in Sandbox, if we downgrade to v0.32.0 we see that's not a problem. On v0.33.0 however, drag is undefined. Not sure if the API has changed or not.

mamsoudi avatar Aug 01 '22 02:08 mamsoudi

Also noticed that since v0.31.0 there's an unexpected change in how group rotation works. Again it's testable in the Sandbox going to v0.30.0 we can see that groups rotate normally (similar to the website). Notice how the behaviour of the rotation handler changes when I switch to v0.31.0: bug

mamsoudi avatar Aug 01 '22 02:08 mamsoudi

@mamsoudi

  • lit-moveable 0.11.2
  • moveable 0.34.2
  • preact-moveable 0.36.2
  • react-compat-moveable 0.22.2
  • react-moveable 0.37.2
  • svelte-moveable 0.26.2
  • vue-moveable 2.0.0-beta.30
  • vue3-moveable 0.9.2
  • ngx-moveable 0.31.2

moveable's new version is released. Check it again.

daybrush avatar Aug 01 '22 18:08 daybrush

Thanks a huge bunch! @daybrush Will give it a try ASAP!

mamsoudi avatar Aug 01 '22 19:08 mamsoudi