Dongbo Wang
Dongbo Wang
> We shouldn't regress in .\file.txt scenario if we will fix the issue. @iSazonov You'd better be specific on what scenario that is :) (link to an issue?).
The Engine Working Group reviewed this issue in the meeting this week. The reported behavior is due to the fact that `AliasInfo` is delay resolved. When calling `Set-Alias -Name alias1...
The exception happens in `DateTimeStorage.Set(int record, object value)` when it cast the value to `IConvertable`: https://source.dot.net/#System.Data.Common/System/Data/Common/DateTimeStorage.cs,165 My investigation shows there has been no change in the related binder code and...
It turns out the regression was caused by the change to the method `IsValueTypeMutable` in #12495, which was included in 7.2.0-preview.2. However, that was a correct change -- before the...
As proposed in https://github.com/PowerShell/PowerShell/pull/19071#discussion_r1092808924, it's probably better to have `PSObject` implements `System.IConvertible`, which will solve this problem and the other problems @ili101 mentioned in https://github.com/PowerShell/PowerShell/pull/19071#issuecomment-1413723688 without having to special-case any...
@gregsdennis Sorry for the delay of response. We will make sure review this PR again next Monday. Thanks!
@adityapatwardhan Can you please review this PR?
> When tracing is disabled, we reduce allocations **even more significantly**. All this already makes this change very useful. Can you please point me to some examples to prove the...
> You can look how WriteLine(string format, object arg1) is used (384 times). Most is strings but there are FileInfo, Uri, StringBuilder, ... Having `FileInfo`, `Uri`, `StringBuilder` passed in to...
Again, I think when tracing is disabled, we ideally should never call to the `WriteLine` methods. That's doable for the parameter binders but may be harder for the uses in...