Dongbo Wang

Results 460 comments of Dongbo Wang

@iSazonov I really like you trying out the source generator! I measured the code you removed from `PSVersionInfo.cs` by using the source generator, and it takes about `7ms` on average...

The current type initializer of PSVersionInfo takes `24-30 ms` on my dev machine, and it happens when creating the banner messgae, which is very early in the startup process. It...

@TravisEz13 and @PaulHigin, can you please review the changes again and re-evaluate the "code injection" concern? Here is the doc (and the sample code) about the source generator: https://learn.microsoft.com/en-us/dotnet/csharp/roslyn-sdk/source-generators-overview The...

@iSazonov Just FYI, I re-did the conflict resolution because you accidentally brough back the `PSCompatibleVersions` property, which was deleted in the other PR.

> Since you mentioned saving build time I think you could be interesting in SG for TypeGen. I don't know if that would save build time, I doubt it :)...

> I am able to use this command successfully in the **windows powershell console**; the error is only thrown in Jupyter and in VSCode when using .NET Interactive @vijaidial By...

Auto loading a module at the time of user pressing Tab is dangerous. It's likely will block the user input for a very noticeable period of time and the user...

@SeeminglyScience FYI, PR https://github.com/PowerShell/PowerShell/pull/18484 was submitted to make those 2 JSON file build artifacts only. Please open doc issue and update the PR check list with the doc issue link.

@SeeminglyScience Thanks! I will merge this PR.

This is great! There are more places to apply this, like all the `WriteVerbose` and `WriteWarning` calls in engine. This will save a great deal of string allocations.