Dongbo Wang

Results 459 comments of Dongbo Wang

The PowerShell sub-kernel host needs to be updated to strip off the VT sequences properly as controlled by `$PSStyle`, and that's not done yet :(

@JamesWTruher can you please review this PR?

> Errors not using `$host.privatedata.ErrorForegroundColor` for ConciseView is by-design. @SteveL-MSFT Can you please clarify this some more? The behavior I observed on 7.2.6 is the opposite -- the `ConciseView` error...

PSReadLine is a separate module, so we can leave that aside. Between `$PSStyle.Formatting` and `$Host.Private`, my understanding based on the documentation is that it's a replacement of `$Host.PrivateData`, however, the...

> Fix: PSStyle variable is currently removable. @SteveL-MSFT, about this one, did you have that variable removable intentionally? If that was intentional, I found the formatting decoration to table headers...

@dkaszews #17987 only addressed the short-term goal (target 7.3) listed in https://github.com/PowerShell/PowerShell/issues/17886#issuecomment-1229015174. The long-term goals are still to be addressed.

@simonsabin `$PSStyle.OutputRendering` applies to error output. Also, setting `NO_COLOR` env variable can also suppress the color in error output: ![image](https://user-images.githubusercontent.com/127450/189959515-b164771a-5c2d-421a-ab4f-88ec79564eef.png)

It feels to me the right behavior for `Out-File -FilePath` may be: - when searching for an existing file, wildcard and escaped wildcard characters are respected, meaning `Out-File -FilePath [ab].txt`...

https://github.com/PowerShell/PowerShell/pull/9258 is an attempt to address the issue reported here for `Out-File -FilePath`. But I think this is a general issue that should be fixed in a wider scope.

Thanks @PaulHigin, the doc issue was opened: https://github.com/MicrosoftDocs/PowerShell-Docs/issues/9231.