moodle-checklist icon indicating copy to clipboard operation
moodle-checklist copied to clipboard

Published 20 hours ago • verified publisher icon davosmith

Phpunit fix for running tests in separate process

Open ccaemmi opened this issue 2 years ago • 5 comments

ccaemmi avatar Jun 16 '23 15:06 ccaemmi

The PHP unit annotation change looks reasonable (not a feature I'm aware of, but happy to accept it). However, the workflow changes are wrong, please could you remove that commit from the pull request?

davosmith avatar Jun 16 '23 17:06 davosmith

I added another commit to revert the workflow changes.

ccaemmi avatar Jun 20 '23 09:06 ccaemmi

This is due to https://tracker.moodle.org/browse/MDL-78049

@ccaemmi can you add the details of the failing test that you were fixing with this

aspark21 avatar Jun 29 '23 17:06 aspark21

@davosmith @aspark21 This is not related to MDL-78049 IMO which was resolving an issue with core tests.

However, currently the external tests of the checklist plugin are failing, because external tests need to be run in a separate process as long as the external functions still depend on the aliases in /externallib.php AFAIK.

PhMemmel avatar Sep 19 '23 07:09 PhMemmel

Fixed via #109

aspark21 avatar Dec 08 '23 03:12 aspark21

This PR can be closed.

lucaboesch avatar Jun 12 '24 23:06 lucaboesch