dinit
dinit copied to clipboard
davmac314
meson build should build test objects with correct compilation flags
According to https://github.com/davmac314/dinit/pull/461 the tests are not being built correctly in the meson builds (the test objects are being compiled with the same flags as the primary build). That should be fixed.
I remember now that this is documented in BUILD_MESON:
1. Sanitizers cannot be enabled only for tests, as they are by default in a Make-based build.
This was fine during development but needs to be sorted. It's not ok that this newer build system has limitations that are trivially overcome by a traditional build.
This is trivially overcome in meson too. The existing meson.build file has simply chosen not to build a second copy of the test objects with different flags.
The fuzzer already enables sanitizers manually, without using meson's global builtin toggle to build "the whole project" with sanitizers. There's absolutely no reason you can't set that up consistently in meson, all you need to do is define your own build option rather than relying on Meson's generic builtin.
The Meson built-in for sanitizer support is intended for people who want to sideload sanitizers into an existing project, usually to run it live on a test system by installing it and emulating normal workflows. It's quite different from "the test suite has dedicated sanitizer targets that must always be run", and people doing the latter are NOT constrained by the existence of helper options intended for people doing the former.
This is trivially overcome in meson too. The existing meson.build file has simply chosen not to build a second copy of the test objects with different flags.
That may be the case. The problem is that Dinit has a contributed meson.build file, which was an unasked-for contribution and was accepted only on the basis that it would be properly maintained by the contributor. This issue is for tracking the fact that it is currently lacking in a specific way that the traditional build handles just fine. The comment about "this newer build system" above is not talking about Meson in general, just Dinit's Meson-based build.