David Xia

Results 116 comments of David Xia

seems like this issue can be closed?

@mattnworb How does https://github.com/spotify/docker-maven-plugin/pull/216 look as a solution? It seems pretty good to me.

Do I have to run one `pip install` on multiple requirement files to get a consistent dependency set? If so, that workaround can result in an inconsistent dependency set, right?

@kynan I can work on this since I need it.

@kynan just made a PR for this in #177. Lmk if you have any questions!

@daikeshi can correct me if I'm wrong, but we've switched our user workflow to creating RayClusters on an as-needed basis via a CLI. So this is less of a concern...

@DmitriGekhtman I just updated to use `.status.head` instead of annotation. Lmk if this draft looks OK and I'll polish it up and mark it ready for review by more people.

Thanks for the initial review. Shall I go ahead and write tests? I also noticed the compatibility test fail. Is that expected?

Added unit tests. Ready for review.