David

Results 135 comments of David

Thanks for that detailed answer. It seems clear for now but of course I will need to test that workflow. I'll let you tell me when this PR is ready...

Hi, from the TODO list above I understand that there are still some tests to be implemented + documentation, is that right?

Also CodeQL is complaining, I'm not sure if we should dismiss those

Hi @GeoDerp, should we proceed to merge or not yet?

Ok I will wait for you to complete the add-on docs part and then merge

> @davidusb-geek, could you have a look at [f754cf9](https://github.com/davidusb-geek/emhass/commit/f754cf99758f2b9869b2cbfa37a929e2eff2b933) , this is just my simple "fix" for the DST issue. However I wouldn't be surprised if this is implemented wrong...

Yes but hard to say why it is behaving like that. What prediction horizon are you using? And it is a constant value or you change it in time?

There was probably an improvement on this based on the fix at PR #430

What is still needed for PV adjust: (UPDATE) - [x] ~~Need to create a common method to retrieve data from HA in `command_line.py`~~ - ~~Before we retrieved only for perfect...

Added attempt to fix issue #495