react-google-flight-datepicker icon indicating copy to clipboard operation
react-google-flight-datepicker copied to clipboard

Published 20 hours ago • verified publisher icon davidtran

TypeScript Declarations

Open YewoMhango opened this issue 3 years ago • 7 comments

There are no existing type declarations for the package on DefinitelyTyped, so it complicates trying to use the package with Typescript projects. I can also try to help out with achieving that if necessary (though I'm not particularly experienced with contributing to Open-source projects as of now)

YewoMhango avatar Nov 24 '22 12:11 YewoMhango

Hi @YewoMhango It would be great if you can provide TypeScript support.

davidtran avatar Nov 24 '22 13:11 davidtran

Hi @davidtran. I've managed to create a version of this project converted to typescript with just type annotations added, and no changes in functionality. Is it possible to upgrade this repo to a Typescript project entirely? If so, then I could create a pull request for that

YewoMhango avatar Dec 14 '22 13:12 YewoMhango

hi @YewoMhango sure, please create a PR for it. I will help you review it.

davidtran avatar Dec 15 '22 02:12 davidtran

Hi @YewoMhango ，will you provide TypeScript support？

arrrrrrrr avatar Apr 07 '23 09:04 arrrrrrrr

Hi @YewoMhango ，will you provide TypeScript support？

Yes, hi there @arrrrrrrr . Somehow I didn't receive (or perhaps see) the email notification for @davidtran 's reply to my request, such that I thought he might have not replied to it. But I guess I'll do it now, then

YewoMhango avatar Apr 07 '23 14:04 YewoMhango

@YewoMhango any update on this? Or @davidtran are you planning to make this change?

shadoath avatar Jun 21 '23 18:06 shadoath

I'll try to see if I have time to switch it to ts, you are welcome to do PR with the latest changes @YewoMhango

Telsho avatar Dec 06 '24 17:12 Telsho