David Torosyan

Results 23 comments of David Torosyan

Here's a screenshot showing that Android Studio (I don't know about other rendering engines) likes to move the samples to the end. ![image](https://github.com/facebook/ktfmt/assets/46736285/4ca211be-b0b1-4db4-ae84-b0cb46820512) Closing as not planned, please comment if...

> Can you explain why you find it surprising that C in included? It is also not included in the sample, but rather just its own paragraph Sure, what I...

@liutikas here's a better example, which demonstrates what I mean. You'll notice in the rendered kdoc that the paragraph between the samples is lost (the line that reads "But you...

Thanks for confirming @tnorbye. This also gives me two ideas: 1. Can we stick a dokka renderer in the ktfmt sample site? That would help us validate issues like this...

Thanks for the update @liutikas! Great to hear from jetbrains about it too. > Would ktfmt be willing to take a PR to add orderDocTags as an option to the...

I think my question from last time still stands: > what scenario would be supporting exactly? If none of the existing tools support rendering inline sample tags, what use would...

@omarismail94 thanks for contributing! That said, right now my thinking is to go the route of special-casing `@sample`. That way users wouldn't have to choose between using `@sample` and any...

Thanks @omarismail94! I actually just implemented this in 2ba3b097656a8447e1c14c6f52a5854a5aac939b, in which I classify `@sample` as a priority tag. Priority tags appear before other tags, but only if they're before them...

@omarismail94 I just fixed the tests with: babb277d0cbb795f2173fcc98cc39e6ed278b102 > See screenshot below of diff: I thought there might be cases like this. I'm not sure if that particular example makes...

@omarismail94 if we do this: > separator between @sample and Kdoc list now removed. Personally, I think it's cleaner with the new line separating. Is there a way to get...