assert-json-diff icon indicating copy to clipboard operation
assert-json-diff copied to clipboard

Feature/implement assert json contains

Open marlon-sousa opened this issue 3 years ago • 9 comments

In this pull request, we implement a new macro called assert_json_contains. Details and specifications at #8

To reviewers, I ask that we first agree on technical implementation and latter further discuss documentation and examples, to be commited still on this pull request.

marlon-sousa avatar Apr 08 '22 18:04 marlon-sousa

LGTM - also big thanks on this one. I like the elegant solution of configuration modification you have for the new macro

dyst5422 avatar Apr 10 '22 16:04 dyst5422

Hello,

Thank you.

Now, can you guide me on what else I need to do?

I am new contributing to crates, so I am not sure if I have to modify version or where and what I have to document.

marlon-sousa avatar Apr 10 '22 21:04 marlon-sousa

Hi, just leaving a note that this would be really helpful for my work! would be happy to provide a little lift to get it over the hump, too

briankung avatar Apr 24 '23 15:04 briankung

I rebased these changes in another branch: https://github.com/davidpdrsn/assert-json-diff/compare/main...briankung:feature/assert-json-contains?expand=1

briankung avatar Apr 24 '23 16:04 briankung

Coming late to this, but this is a great feature! However, this repository seems to be abandoned since April 2022 (correct me if I'm wrong, @davidpdrsn)... @briankung would you consider picking up the project and publish your fork on crates.io?

Syndelis avatar Nov 12 '23 16:11 Syndelis

Not interested, but you can use my branch as a dependency if you like, or fork it yourself.

briankung avatar Nov 13 '23 02:11 briankung

I'm up for transferring ownership to someone else if anyone is up for take up the mantle.

davidpdrsn avatar Nov 13 '23 10:11 davidpdrsn

Hello, David.Can you write me privately, so that I can ask you some questions about, from anoperational points of view, I can maintain this? Depending on how things go, I can do it.Obrigado,MarlonEm 13 de nov. de 2023, à(s) 07:18, David Pedersen @.***> escreveu: I'm up for transferring ownership to someone else if anyone is up for take up the mantle.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

marlon-sousa avatar Nov 13 '23 10:11 marlon-sousa

David.Can you write me privately, so that I can ask you some questions about, from anoperational points of view, I can maintain this

Sure! How should I message you?

davidpdrsn avatar Nov 13 '23 10:11 davidpdrsn