apiosintDS icon indicating copy to clipboard operation
apiosintDS copied to clipboard

Published 20 hours ago • verified publisher icon davidonzo

Remove misp-module branch

Open ostefano opened this issue 2 years ago • 1 comments

I see that the misp-module branch is used to unpin the validators dependency. My understanding is because we want to make it compatible with the list of dependencies used by misp-module (https://github.com/MISP/misp-modules/blob/main/REQUIREMENTS).

It turns out validators is used only by apiosintDS so it should be safe to:

  • pin the version inside misp-module
  • remove the misp-module branch from apiosintDS

ostefano avatar Sep 12 '23 09:09 ostefano

CC @davidonzo

ostefano avatar Dec 28 '23 22:12 ostefano

Sorry for the very long dalay in the answer... Anyway, this should fix the issue => https://github.com/MISP/misp-modules/pull/666

Once the PR will be merged the misp-module branch become useless. But of course, I'll wait the PR merge before delete the branch.

Thanks. Regards

davidonzo avatar May 28 '24 17:05 davidonzo

PR merged. The issue is resolved.

davidonzo avatar May 29 '24 06:05 davidonzo