David Mark Clements comments

Results 118 comments of


                                            David Mark Clements

Create Child Logger with Options

the option keys of the parent - but we need a strict subset of options for the child logger that will replace the parent. These need to be only that...

Level-based redaction

Actually... if you described the parts of the object you want to log with json schema this could be made very fast - Matteo I’m thinking we can use the...

[Suggestion] Browser API: add fully-formatted log message to logEvent

The logEvent format is designed to represent the structure of a logger instance., so that, when you send the logEvent from client to server, all the server has to do...

Missing documentation for serializers API

yes, we'll need to add a new doc: serializers.md

update _currentElement to nextElement to trigger correct event handlers

btw this will cause a merge conflict with #38 - in this case we just need to take both sides of the conflict

update _currentElement to nextElement to trigger correct event handlers

@Yomguithereal - would a hangouts session with explanations help to clear these PR's?

update _currentElement to nextElement to trigger correct event handlers

no conflicts, other than the merge conflict noted above - all very much relevant I have a patches branch with them all working together https://github.com/davidmarkclements/react-blessed/tree/patches

update _currentElement to nextElement to trigger correct event handlers

potentially - I've not experienced any as yet. If you don't do it there are already known side effects (firing old handlers) - ideally we want to update the element...

update _currentElement to nextElement to trigger correct event handlers

ping :)

Proposal: <screen /> root component

alternatively return both screen and component? ``` js import {Screen, render} from 'react-blessed'; const App = () => ( Hello World! ); const {screen, component} = render(); ``` could attach...