David Koski

Results 272 comments of David Koski

OK, what is the value of the type/modelType? That needs to match this list: - https://github.com/ml-explore/mlx-swift-examples/blob/main/Libraries/MLXLLM/LLMModelFactory.swift#L31

yes, that sounds like you are using an older checkout / tag, but from your screenshot you are up-to-date. If you cmd-click on that symbol, see what source it jumps...

OK, perhaps we can catch it failing and see something that way. This method in `ModelTypeRegistry` is what throws the error: ```swift public func createModel(configuration: URL, modelType: String) throws ->...

My guess is that there are somehow _two_ copies of `mlx-swift` or `mlx-libraries` (the package inside of `mlx-swift-examples`). One is current and one is older and the older one is...

FYI #294 added qwen3 MOE

I agree it isn't used by the Libraries, but it is now used by the Applications.

> I tried to factor out `RMSNorm`, since several models use it, but I'm having trouble making it accessible everywhere. There is one in MLXNN as well, but they don't...

> I fixed some more errors, and now there are just a few errors and TODO comments left, which I'll need help resolving. I can take a look this afternoon!

> The config is working, although it can probably be improved (see TODO comment and possibly remove unneeded properties). But now I'm getting the following error when I run the...

So I think some of the transformers code needs to be included in the UserInputProcessor, along the lines of this from paligemma: ``` // based on transformers/processing_paligemma let count =...