david g.

Results 376 comments of david g.

@Lovekeshgoel ... I cant seem to replicate this ... it looks like your query parameters are coming as escaped, and thats how theyre getting fed into AEM Query engine ......

@mayurijadhav17 im skeptical anyone is going to pick this one up - can you please make a PR with the desired tests, and well merge them in. Thank you!

@Robedean - i have an old branch with this - let me see if i can find it and PR it in.

Hows this look? https://github.com/adobe/asset-share-commons/pull/1060

This has been released in 3.7.0

Pagination was never released - I think you could create a component tho that performs pagination. All should be is setting the offset and limit when a new page is...

For posterity .. this was added some time ago, and can be set via the Search Results component: ![2023-12-12 at 12 16 PM](https://github.com/adobe/asset-share-commons/assets/1451868/0211915d-0d85-48e6-9c38-b5793f5502db)

@dkfellows - So the `-DrepoToken` needs to be the Github token and NOT the Coveralls Repo Token (that you get from coveralls.io ?)

@MarcusOhman91 Checkout the solution here: https://stackoverflow.com/questions/76149553/next-js-react-18-google-maps-js-api-not-clearing-prior-map-state/76150188#76150188 This is how i ended up fixing/working around this.