iframe-resizer icon indicating copy to clipboard operation
iframe-resizer copied to clipboard

fix readDataFromParent mouseEvents Boolean to strBool

Open tonyliving opened this issue 4 years ago • 3 comments

readDataFromParent mouseEvents Boolean to strBool

tonyliving avatar Sep 03 '21 05:09 tonyliving

What is the reason for changing this?

davidjbradshaw avatar Nov 01 '21 10:11 davidjbradshaw

Boolean("false") --> ture wrong strBool("false")-->false right

You can try to set in parent page

iframeResizer( { mouseEvents:false }, document.getElementById("iframe") )

https://github.com/davidjbradshaw/iframe-resizer/blob/f0adaca23aa71e87c28546cbf32dd1fbcb6450ae/src/iframeResizer.contentWindow.js#L211

https://github.com/davidjbradshaw/iframe-resizer/blob/f0adaca23aa71e87c28546cbf32dd1fbcb6450ae/src/iframeResizer.contentWindow.js#L214

You can compare these two lines.What to do with boolean values

tonyliving avatar Nov 02 '21 06:11 tonyliving

@davidjbradshaw

tonyliving avatar Nov 13 '21 00:11 tonyliving

Released as v4.3.4

Sorry for the delay, I have been very ill for the last year.

davidjbradshaw avatar Feb 18 '23 17:02 davidjbradshaw