David J. Bradshaw

Results 214 comments of David J. Bradshaw

That sounds like a bug with tree-shaking. Might be worth reporting over at WebPack.

It would be great if @arminbaljic or someone else in the Angular community would publish an Angular wrapper to this project, like we have with https://github.com/davidjbradshaw/iframe-resizer-react

@arminbaljic thanks for the input on that. The only comment I have is this line. ``` this.component = components && components.length > 0 ? components[0] : null; ``` If you...

If you only have one iFrame, it will return a one element array

@alfupe of yes I see it is passing `this.element.nativeElement` to `iframeResize()`, so in that case it will only get one element back. It is possible to pass looser selectors, rather...

@Elka74100 I have no idea, never used Angular, if you find that you need to do something new in version 9, can you please update this thread.

Just a normal PR should be fine and sorry for late reply, I have been somewhat unwell of late

I'm a bit confused, what version do you think it is on?

I don't think `sandbox="allow-same-origin"` does what you think it does