serverless-plugin-canary-deployments
serverless-plugin-canary-deployments copied to clipboard
Please add ALB Events to the supported list.
Please add ALB events as well to the list of supported events.
Appreciate it!
Any other comments?
In the current list of events supported by serverless-plugin-canary-deployments, ALB events are not supported. With Lambdas being exposed over ALB (instead of API Gateway) is becoming a popular pattern since AWS announced it 18 months ago, it makes a perfect puzzle piece to address.
Looking forward to what you think!
There's already a PR in place for this #85, I'm just waiting for a couple of changes before merging it.
Hi, PR #85 was closed but I'm not sure if ALB is supported now or not.
Hi,
I tried this package with an internal ALB, and it doesn't work. The ALB Target Group use the $LATEST version instead of the Alias, but the resource policy that allows the ALB to instantiate the lambda is on the Alias (and not anymore on the $LATEST version, so it breaks the configuration).
Could you please add support to ALB events ?
@davidgf : Is this project still maintained ?
@JeremieDemarchez due to personal and professional reasons, I don't have time to implement or review changes. I'm also reluctant to merge anything that I haven't tested thoroughly, specially taking into account that this plugin handles deployments. Having said that, this is an open source project, and you are free to take the code and modify it as you see fit.
@davidgf I can totally understand the lack of time, I'm in the same situation. Thank you for confirming that it is no longer actively maintained. Sorry if you took it as a reproach, it was just a question. Good luck.
Hi everyone, we have added ElasticLoadBalancingV2 TargetGroups support to our fork and published it to npm.
We also solved #94 and bumped a bunch of dependencies.
You can try npm i @flagsmith/serverless-plugin-canary-deployments and tell us what you think!