serverless-plugin-canary-deployments icon indicating copy to clipboard operation
serverless-plugin-canary-deployments copied to clipboard

Please add ALB Events to the supported list.

Open ramgrandhi opened this issue 5 years ago • 7 comments

Please add ALB events as well to the list of supported events.

Appreciate it!

Any other comments?

In the current list of events supported by serverless-plugin-canary-deployments, ALB events are not supported. With Lambdas being exposed over ALB (instead of API Gateway) is becoming a popular pattern since AWS announced it 18 months ago, it makes a perfect puzzle piece to address.

Looking forward to what you think!

ramgrandhi avatar Aug 01 '20 22:08 ramgrandhi

There's already a PR in place for this #85, I'm just waiting for a couple of changes before merging it.

davidgf avatar Aug 11 '20 18:08 davidgf

Hi, PR #85 was closed but I'm not sure if ALB is supported now or not.

hlhl040 avatar Sep 01 '21 16:09 hlhl040

Hi,

I tried this package with an internal ALB, and it doesn't work. The ALB Target Group use the $LATEST version instead of the Alias, but the resource policy that allows the ALB to instantiate the lambda is on the Alias (and not anymore on the $LATEST version, so it breaks the configuration).

Could you please add support to ALB events ?

JeremieDemarchez avatar Nov 02 '23 08:11 JeremieDemarchez

@davidgf : Is this project still maintained ?

JeremieDemarchez avatar Nov 14 '23 10:11 JeremieDemarchez

@JeremieDemarchez due to personal and professional reasons, I don't have time to implement or review changes. I'm also reluctant to merge anything that I haven't tested thoroughly, specially taking into account that this plugin handles deployments. Having said that, this is an open source project, and you are free to take the code and modify it as you see fit.

davidgf avatar Nov 14 '23 12:11 davidgf

@davidgf I can totally understand the lack of time, I'm in the same situation. Thank you for confirming that it is no longer actively maintained. Sorry if you took it as a reproach, it was just a question. Good luck.

JeremieDemarchez avatar Nov 17 '23 16:11 JeremieDemarchez

Hi everyone, we have added ElasticLoadBalancingV2 TargetGroups support to our fork and published it to npm.

We also solved #94 and bumped a bunch of dependencies.

You can try npm i @flagsmith/serverless-plugin-canary-deployments and tell us what you think!

khvn26 avatar Jan 08 '24 18:01 khvn26