serverless-plugin-canary-deployments icon indicating copy to clipboard operation
serverless-plugin-canary-deployments copied to clipboard

feat: allow lambda ARN to be used for deployment hooks

Open AkiraJ48 opened this issue 3 years ago • 2 comments
trafficstars

Proposed changes

Currently you cannot specify an ARN for the deployment hooks preTrafficHook and postTrafficHook. The deployment hooks only expect a resource name that should exist within the cloudformation stack.

This change will allow us to have a single global lambda that will be invoked by code deploy instead of needing a lambda per cloudformation stack.

Types of changes

What types of changes does your code introduce to the plugin? Put an x in the boxes that apply

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x] Lint and unit tests pass locally with my changes
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added necessary documentation (if appropriate)

Further comments

I opted for a relatively simple check on whether the given input is an ARN. Happy to introduce something like @aws-sdk/util-arn-parser instead if that's preferable.

AkiraJ48 avatar Apr 06 '22 06:04 AkiraJ48

Hi @davidgf, when you have time could you please take a look at this PR 😄 ?

AkiraJ48 avatar Apr 12 '22 01:04 AkiraJ48

Hi @davidgf sorry for bothering you, have you had some time to look at this PR?

AkiraJ48 avatar May 11 '22 22:05 AkiraJ48