pixi-viewport icon indicating copy to clipboard operation
pixi-viewport copied to clipboard

Upgrade pixi.js to v6.5

Open stevensnoeijen opened this issue 3 years ago • 5 comments
trafficstars

The current build on pixi-viewport does not work with v6.5.0 because of changes in the pixi's DisplayObject.

Issue for this PR: https://github.com/davidfig/pixi-viewport/issues/391

Changes:

Please merge https://github.com/davidfig/pixi-viewport/pull/392 before merging this PR, this PR branch is extended from the electron fix.

stevensnoeijen avatar Aug 01 '22 11:08 stevensnoeijen

The formatting changes make this merge seem much larger than it is

kurtwaldowski-echelon avatar Aug 02 '22 20:08 kurtwaldowski-echelon

The formatting changes make this merge seem much larger than it is

Good point I'll check this tomorrow

stevensnoeijen avatar Aug 02 '22 20:08 stevensnoeijen

The formatting changes make this merge seem much larger than it is

The formatting you mean is on the dist folder which is generated though yarn build and can be ignored, because I did not directly changed that. I did just run build this so that I can use these changes in the meanwhile. When @davidfig creates a new release he probably run this again himself.

stevensnoeijen avatar Aug 03 '22 09:08 stevensnoeijen

The formatting changes make this merge seem much larger than it is

The formatting you mean is on the dist folder which is generated though yarn build and can be ignored, because I did not directly changed that. I did just run build this so that I can use these changes in the meanwhile. When @davidfig creates a new release he probably run this again himself.

Derp good point! Thanks!

kurtwaldowski-echelon avatar Aug 05 '22 22:08 kurtwaldowski-echelon

bump @davidfig

stevensnoeijen avatar Aug 08 '22 18:08 stevensnoeijen

Thanks!

davidfig avatar Aug 13 '22 12:08 davidfig