tracing-tree icon indicating copy to clipboard operation
tracing-tree copied to clipboard

Make ansi colors compile time feature

Open matklad opened this issue 4 years ago • 2 comments

I've noticed that we always configure tracing tree with with_ansi(false) in rust-analyzer, so I think we can shave a couple of dependencies off here!

matklad avatar Aug 31 '21 21:08 matklad

That seems like a candidate for a cargo feature! I'll try to get to this tomorrow.

davidbarsky avatar Sep 02 '21 22:09 davidbarsky

Bit of a late update on this: I gave this a spin, but separating all the ansi-formatting functionality to exist behind a feature flag is kinda annoying, and at the time, I didn't really have a good idea how to handle it. I do now (based off a pattern I saw Eliza do in tracing-subscriber), but I think it won't make it into today's release. I'm sorry about that!

davidbarsky avatar Dec 05 '21 21:12 davidbarsky